This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
Implement SIMD load splat and load extend #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rossberg this is an alternative to #306. We add more cases to I think I like this more, no other types will use the new pack types, but I don't think that's much of a problem - we add an |
ngzhian
added a commit
to ngzhian/simd
that referenced
this pull request
Aug 25, 2020
This enables running all the SIMD tests (in test/core/simd) whenever we do `make test`. This should not be submitted yet, it depends on WebAssembly#306 or WebAssembly#307 for the implementation of load splats and loads extends.
This was referenced Aug 25, 2020
Merged
ngzhian
force-pushed
the
simd-load-splat-extend-merged
branch
2 times, most recently
from
195d7d9
to
301cdbd
Compare
Add more pack types for SIMD load splat and load extends.
ngzhian
force-pushed
the
simd-load-splat-extend-merged
branch
from
301cdbd
to
d051fb6
Compare
rossberg
reviewed
Aug 27, 2020
binji
approved these changes
Aug 28, 2020
ngzhian
added a commit
to ngzhian/simd
that referenced
this pull request
Sep 1, 2020
This enables running all the SIMD tests (in test/core/simd) whenever we do `make test`. This should not be submitted yet, it depends on WebAssembly#306 or WebAssembly#307 for the implementation of load splats and loads extends.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more pack types for SIMD load splat and load extends.
This currently uses the old names, after the sync next week we will decide on #322 and I can add a follow-up patch to address the changes.